Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added icons to the IOU payments mode #3852

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Added icons to the IOU payments mode #3852

merged 3 commits into from
Jul 1, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 1, 2021 •
edited
Loading

Details

Fixed Issues

$ fixes #3791

Tests | QA Steps

1. Click the + icon and select Request Money
2. Enter an amount and click next
3. Select an attendee and then click confirm
4. Log-in to the account you just sent the request to
5. Click the badge icon on the chat row in the LHN to access the IOUDetails modal
6. Click the v on the confirmation button to access the payment method selector.
7. You should see icons with all methods.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iOS

Android

Screenshot 2021-07-01 16:54:21

@parasharrajat parasharrajat requested a review from a team as a code owner July 1, 2021 11:12
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team July 1, 2021 11:18
@parasharrajat
Copy link
Member Author

@MonilBhavsar updated.

@MonilBhavsar MonilBhavsar merged commit 78238db into Expensify:main Jul 1, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

@parasharrajat parasharrajat deleted the pay-icons branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HOLD for payment on July 8] Add icons to the IOU payment methods
4 participants
@parasharrajat @OSBotify @roryabraham @MonilBhavsar